Re: [Mesa-dev] [PATCH 1/2] i965: Add cases for ir_binop_vector_extract that assert.

2013-05-17 Thread Eric Anholt
Eric Anholt writes: > Kenneth Graunke writes: > >> do_vec_index_to_swizzle() should remove any vector extract operations >> with a constant index. It's unconditionally called from >> do_common_optimization(). >> >> do_vec_index_to_cond_assign() should remove the rest, and it is >> unconditional

Re: [Mesa-dev] [PATCH 1/2] i965: Add cases for ir_binop_vector_extract that assert.

2013-05-17 Thread Eric Anholt
Kenneth Graunke writes: > do_vec_index_to_swizzle() should remove any vector extract operations > with a constant index. It's unconditionally called from > do_common_optimization(). > > do_vec_index_to_cond_assign() should remove the rest, and it is > unconditionally called from brw_link_shader(

Re: [Mesa-dev] [PATCH 1/2] i965: Add cases for ir_binop_vector_extract that assert.

2013-05-17 Thread Matt Turner
On Fri, May 17, 2013 at 10:43 AM, Kenneth Graunke wrote: > do_vec_index_to_swizzle() should remove any vector extract operations > with a constant index. It's unconditionally called from > do_common_optimization(). > > do_vec_index_to_cond_assign() should remove the rest, and it is > unconditiona

[Mesa-dev] [PATCH 1/2] i965: Add cases for ir_binop_vector_extract that assert.

2013-05-17 Thread Kenneth Graunke
do_vec_index_to_swizzle() should remove any vector extract operations with a constant index. It's unconditionally called from do_common_optimization(). do_vec_index_to_cond_assign() should remove the rest, and it is unconditionally called from brw_link_shader(). This means that we should never s