Re: [Mesa-dev] [PATCH 1/2] i965/fs: Rewrite assign_constant_locations

2017-12-06 Thread Chema Casanova
I've tested this patch against the VK-CTS push constant 16-bit tests, and enabled storagePushConstant16 at VK_KHR_16bit_storage. All test pass without any extra modification. dEQP-VK.spirv_assembly.instruction.compute.16bit_storage.push_constant.* dEQP-VK.spirv_assembly.instruction.graphics.16bit_

[Mesa-dev] [PATCH 1/2] i965/fs: Rewrite assign_constant_locations

2017-12-03 Thread Jason Ekstrand
This rewires the logic for assigning uniform locations to work in terms of "complex alignments". The basic idea is that, as we walk the list of instructions, we keep track of the alignment and continuity requirements of each slot and assert that the alignments all match up. We then use those alig