Re: [Mesa-dev] [PATCH 1/2] glsl: replace unreachable code with an assert()

2016-02-05 Thread Kenneth Graunke
On Wednesday, February 3, 2016 10:26:07 AM PST Timothy Arceri wrote: > All interface blocks will have been lowered by this point so just > use an assert. Returning false would have caused all sorts of > problems if they were not lowered yet and there is an assert to > catch this later anyway. > >

[Mesa-dev] [PATCH 1/2] glsl: replace unreachable code with an assert()

2016-02-02 Thread Timothy Arceri
All interface blocks will have been lowered by this point so just use an assert. Returning false would have caused all sorts of problems if they were not lowered yet and there is an assert to catch this later anyway. We also update the tests to reflect this change. --- src/compiler/glsl/link_vary