Re: [Mesa-dev] [PATCH 1/2] glsl: don't attempt to link empty program

2016-01-25 Thread Ian Romanick
On 01/25/2016 03:56 AM, Timothy Arceri wrote: > Previously an empty program would go through the entire > link_shaders() function and we would have to be careful > not to cause a segfault. > > We also now set link_status to false by throwing an error, > it was previously set to true. > > From Sec

[Mesa-dev] [PATCH 1/2] glsl: don't attempt to link empty program

2016-01-25 Thread Timothy Arceri
Previously an empty program would go through the entire link_shaders() function and we would have to be careful not to cause a segfault. We also now set link_status to false by throwing an error, it was previously set to true. From Section 7.3 (PROGRAM OBJECTS) of the OpenGL 4.5 spec: "Linkin