Re: [Mesa-dev] [PATCH 1/2] glsl: add is_lhs bool on ast_expression

2016-03-03 Thread Alejandro Piñeiro
All the points made were somewhat small (afaiu). So just in case my answer were missed. Ping. On 29/02/16 07:58, Alejandro Piñeiro wrote: > > On 26/02/16 22:15, Ian Romanick wrote: >> On 02/26/2016 07:09 AM, Alejandro Piñeiro wrote: >>> Useful to know if a expression is the recipient of an assignm

Re: [Mesa-dev] [PATCH 1/2] glsl: add is_lhs bool on ast_expression

2016-02-28 Thread Alejandro Piñeiro
On 26/02/16 22:15, Ian Romanick wrote: > On 02/26/2016 07:09 AM, Alejandro Piñeiro wrote: >> Useful to know if a expression is the recipient of an assignment >> or not, that would be used to (for example) raise warnings of >> "use of uninitialized variable" without getting a false positive >> whe

Re: [Mesa-dev] [PATCH 1/2] glsl: add is_lhs bool on ast_expression

2016-02-26 Thread Ian Romanick
On 02/26/2016 07:09 AM, Alejandro Piñeiro wrote: > Useful to know if a expression is the recipient of an assignment > or not, that would be used to (for example) raise warnings of > "use of uninitialized variable" without getting a false positive > when assigning first a variable. > > By default t

[Mesa-dev] [PATCH 1/2] glsl: add is_lhs bool on ast_expression

2016-02-26 Thread Alejandro Piñeiro
Useful to know if a expression is the recipient of an assignment or not, that would be used to (for example) raise warnings of "use of uninitialized variable" without getting a false positive when assigning first a variable. By default the value is false, and it is assigned to true on the followin