Re: [Mesa-dev] [PATCH 1/2] glsl: Match order of gl_LightSourceParameters elements.

2017-12-02 Thread Fabian Bieler
Thanks again for the review. Since I don't have Mesa git access (only Piglit) a little push would be appreciated. ;) I'll send the commit IDs to mesa-stable as suggested though I'm not sure if the gl_NormalScale fix is worth the trouble. I don't think _anyone_ is using that feature. On 2017-11-29

Re: [Mesa-dev] [PATCH 1/2] glsl: Match order of gl_LightSourceParameters elements.

2017-11-29 Thread Brian Paul
Reviewed-by: Brian Paul I think you could tag both of your patches for the stable branch. On 11/23/2017 01:48 PM, Fabian Bieler wrote: spotExponent and spotCosCutoff were swapped in the gl_builtin_uniform_element struct. Now the order matches across gl_builtin_uniform_element, glsl_struct_fiel

[Mesa-dev] [PATCH 1/2] glsl: Match order of gl_LightSourceParameters elements.

2017-11-23 Thread Fabian Bieler
spotExponent and spotCosCutoff were swapped in the gl_builtin_uniform_element struct. Now the order matches across gl_builtin_uniform_element, glsl_struct_field and the spec. --- src/compiler/glsl/builtin_variables.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/com