Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA (v2)

2015-03-05 Thread Ilia Mirkin
Series is: Reviewed-by: Ilia Mirkin On Thu, Mar 5, 2015 at 11:15 AM, Marek Olšák wrote: > From: Marek Olšák > > Needed by ARB_gpu_shader5. > > v2: select DMAD for FMA with double precision; it can be later changed to DFMA > --- > src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + > src/

[Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA (v2)

2015-03-05 Thread Marek Olšák
From: Marek Olšák Needed by ARB_gpu_shader5. v2: select DMAD for FMA with double precision; it can be later changed to DFMA --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/auxiliary/tgsi/tgsi_info.c | 2

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Roland Scheidegger
Am 02.03.2015 um 21:27 schrieb Marek Olšák: > On Mon, Mar 2, 2015 at 9:16 PM, Roland Scheidegger wrote: >> Am 02.03.2015 um 20:50 schrieb Ilia Mirkin: >>> On Mon, Mar 2, 2015 at 2:44 PM, Marek Olšák >>> wrote: On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin wrote: > Like Roland mention

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 9:16 PM, Roland Scheidegger wrote: > Am 02.03.2015 um 20:50 schrieb Ilia Mirkin: >> On Mon, Mar 2, 2015 at 2:44 PM, Marek Olšák >> wrote: >>> On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin >>> wrote: Like Roland mentioned, you need to add DFMA, and the relevant case

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Ilia Mirkin
On Mon, Mar 2, 2015 at 3:16 PM, Roland Scheidegger wrote: > Am 02.03.2015 um 20:50 schrieb Ilia Mirkin: >> On Mon, Mar 2, 2015 at 2:44 PM, Marek Olšák >> wrote: >>> On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin >>> wrote: Like Roland mentioned, you need to add DFMA, and the relevant case

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Roland Scheidegger
Am 02.03.2015 um 20:50 schrieb Ilia Mirkin: > On Mon, Mar 2, 2015 at 2:44 PM, Marek Olšák > wrote: >> On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin >> wrote: >>> Like Roland mentioned, you need to add DFMA, and the relevant >>> cases to glsl_to_tgsi_visitor::get_opcode so that it can be >>> selecte

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Ilia Mirkin
On Mon, Mar 2, 2015 at 2:44 PM, Marek Olšák wrote: > On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin wrote: >> Like Roland mentioned, you need to add DFMA, and the relevant cases to >> glsl_to_tgsi_visitor::get_opcode so that it can be selected. > > I plan to add DFMA too, but it's really low priorit

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 5:09 PM, Ilia Mirkin wrote: > Like Roland mentioned, you need to add DFMA, and the relevant cases to > glsl_to_tgsi_visitor::get_opcode so that it can be selected. I plan to add DFMA too, but it's really low priority for me right now. I can wait with this patch until it bec

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 5:48 PM, Roland Scheidegger wrote: > Am 02.03.2015 um 17:12 schrieb Marek Olšák: >> On Mon, Mar 2, 2015 at 4:55 PM, Roland Scheidegger >> wrote: >>> Am 02.03.2015 um 12:52 schrieb Marek Olšák: From: Marek Olšák Needed by ARB_gpu_shader5. --- src/

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Roland Scheidegger
Am 02.03.2015 um 17:12 schrieb Marek Olšák: > On Mon, Mar 2, 2015 at 4:55 PM, Roland Scheidegger wrote: >> Am 02.03.2015 um 12:52 schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> Needed by ARB_gpu_shader5. >>> --- >>> src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + >>> src/gallium/aux

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
On Mon, Mar 2, 2015 at 4:55 PM, Roland Scheidegger wrote: > Am 02.03.2015 um 12:52 schrieb Marek Olšák: >> From: Marek Olšák >> >> Needed by ARB_gpu_shader5. >> --- >> src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + >> src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + >> src/gall

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Ilia Mirkin
Like Roland mentioned, you need to add DFMA, and the relevant cases to glsl_to_tgsi_visitor::get_opcode so that it can be selected. On Mon, Mar 2, 2015 at 6:52 AM, Marek Olšák wrote: > From: Marek Olšák > > Needed by ARB_gpu_shader5. > --- > src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1

Re: [Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Roland Scheidegger
Am 02.03.2015 um 12:52 schrieb Marek Olšák: > From: Marek Olšák > > Needed by ARB_gpu_shader5. > --- > src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + > src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + > src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- > src/gallium/aux

[Mesa-dev] [PATCH 1/2] gallium: add TGSI_OPCODE_FMA

2015-03-02 Thread Marek Olšák
From: Marek Olšák Needed by ARB_gpu_shader5. --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_util.c | 1 + src/gallium/docs/s