Re: [Mesa-dev] [PATCH 1/2] egl: Convert int to attrib in eglGetPlatformDisplay

2017-11-17 Thread Emil Velikov
On 16 November 2017 at 18:27, Adam Jackson wrote: > ... because converting attrib to int truncates, and that's bad. > I seems to recall mentioning the same thing as _eglConvertIntsToAttribs Indeed truncating is bad - fortunately we don't have a case where that matters.. With Eric's comment the pa

Re: [Mesa-dev] [PATCH 1/2] egl: Convert int to attrib in eglGetPlatformDisplay

2017-11-17 Thread Eric Engestrom
On Thursday, 2017-11-16 13:27:27 -0500, Adam Jackson wrote: > ... because converting attrib to int truncates, and that's bad. > > Signed-off-by: Adam Jackson > --- > src/egl/main/eglapi.c | 29 ++--- > src/egl/main/egldisplay.c | 15 --- > src/egl/main/egl

[Mesa-dev] [PATCH 1/2] egl: Convert int to attrib in eglGetPlatformDisplay

2017-11-16 Thread Adam Jackson
... because converting attrib to int truncates, and that's bad. Signed-off-by: Adam Jackson --- src/egl/main/eglapi.c | 29 ++--- src/egl/main/egldisplay.c | 15 --- src/egl/main/egldisplay.h | 8 3 files changed, 26 insertions(+), 26 deletions(-