Am 03.11.2016 um 18:44 schrieb Jose Fonseca:
> Patch 1 looks good to me. Yes, not using compilation key is a recipe
> for problems.
Indeed. Thankfully no longer used in generate_fetch(). There's still
some state used not from the key, but that's just information belonging
the the shader itself, so
Am 03.11.2016 um 11:48 schrieb Nicolai Hähnle:
> On 03.11.2016 02:15, srol...@vmware.com wrote:
>> From: Roland Scheidegger
>>
>> Previous fixes were incomplete - some code still iterated through the
>> number
>> of elements provided by velem layout instead of the number stored in
>> the key
>> (w
Patch 1 looks good to me. Yes, not using compilation key is a recipe for
problems.
Regarding patch 2, I need a bit more time to review. I'd also like the new
lp_build_umul... function to be added to lp_bld_arit: there is a single caller
note, but that might change in the future, so might as we
On 03.11.2016 02:15, srol...@vmware.com wrote:
From: Roland Scheidegger
Previous fixes were incomplete - some code still iterated through the number
of elements provided by velem layout instead of the number stored in the key
(which is the same as the number defined by the vs). And also actuall
From: Roland Scheidegger
Previous fixes were incomplete - some code still iterated through the number
of elements provided by velem layout instead of the number stored in the key
(which is the same as the number defined by the vs). And also actually
accessed the elements from the layout directly
