Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-11-10 Thread Emil Velikov
On 27 October 2016 at 17:06, Gurchetan Singh wrote: > In Android, the pthreads libs are in bionic. When building > Mesa for Android with the autotools workflow, we shouldn't > set -lpthread or -pthread. > --- > configure.ac | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-31 Thread Emil Velikov
On 31 October 2016 at 16:27, Gurchetan Singh wrote: > Why would PTHREAD_LIBS ever be set at all? Isn't the reason for the > proposed cleanup is we've been passing -pthread as a lib instead of as a > linker flag? > -pthread is the most common scenario, but there are others - if bored skim through

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-31 Thread Gurchetan Singh
Why would PTHREAD_LIBS ever be set at all? Isn't the reason for the proposed cleanup is we've been passing -pthread as a lib instead of as a linker flag? On Fri, Oct 28, 2016 at 5:23 PM, Emil Velikov wrote: > On Friday, 28 October 2016, Gurchetan Singh > wrote: > >> I'm confused what the desir

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-30 Thread Gurchetan Singh
Removing the entire hunk causes build failures on CrOS mesa. Refer to this for more information: http://stackoverflow.com/questions/17055279/autotools- for-pthreads-not-setting-correct-linker-flags We can do one of the following: (1) Keep as is, with special case for android (2) Set PTHREAD_LIB

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Emil Velikov
On Friday, 28 October 2016, Gurchetan Singh wrote: > I'm confused what the desired cleanup is. Do you want > > 1) PKG_CHECK_MODULES(PTHREAD, [pthread]) in configure.ac > or > 2) All references to PTHREAD_LIBS in the configure.ac and the makefiles > to be removed. In the cases where this breaks

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Gurchetan Singh
I'm confused what the desired cleanup is. Do you want 1) PKG_CHECK_MODULES(PTHREAD, [pthread]) in configure.ac or 2) All references to PTHREAD_LIBS in the configure.ac and the makefiles to be removed. In the cases where this breaks the build, PTHREAD_CFLAGS should be added to the AM_LDFLAGS. O

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Emil Velikov
On 28 October 2016 at 19:35, Gurchetan Singh wrote: > Removing the entire hunk causes build failures on CrOS mesa. Refer to this > for more information: > > http://stackoverflow.com/questions/17055279/autotools-for-pthreads-not-setting-correct-linker-flags > > We can do one of the following: > >

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Emil Velikov
On 28 October 2016 at 18:24, Matt Turner wrote: > On Fri, Oct 28, 2016 at 8:06 AM, Emil Velikov > wrote: >> On 27 October 2016 at 17:06, Gurchetan Singh >> wrote: >>> In Android, the pthreads libs are in bionic. When building >>> Mesa for Android with the autotools workflow, we shouldn't >>> s

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Gurchetan Singh
Removing the entire hunk causes build failures on CrOS mesa. Refer to this for more information: http://stackoverflow.com/questions/17055279/autotools-for-pthreads-not-setting-correct-linker-flags We can do one of the following: (1) Keep as is, with special case for android (2) Set PTHREAD_LIBS

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Matt Turner
On Fri, Oct 28, 2016 at 8:06 AM, Emil Velikov wrote: > On 27 October 2016 at 17:06, Gurchetan Singh > wrote: >> In Android, the pthreads libs are in bionic. When building >> Mesa for Android with the autotools workflow, we shouldn't >> set -lpthread or -pthread. >> --- >> configure.ac | 7 +

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-28 Thread Emil Velikov
On 27 October 2016 at 17:06, Gurchetan Singh wrote: > In Android, the pthreads libs are in bionic. When building > Mesa for Android with the autotools workflow, we shouldn't > set -lpthread or -pthread. > --- > configure.ac | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff

[Mesa-dev] [PATCH 1/2] configure.ac: Don't look for pthreads in Android platform

2016-10-27 Thread Gurchetan Singh
In Android, the pthreads libs are in bionic. When building Mesa for Android with the autotools workflow, we shouldn't set -lpthread or -pthread. --- configure.ac | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 4761c59..3f21cd5 100644 --