Grigori Goronzy writes:
> On 2015-06-09 22:52, Francisco Jerez wrote:
>>> +
>>> + if (blocking)
>>> + hev().wait();
>>> +
>>
>> hard_event::wait() may fail, so this should probably be done before the
>> ret_object() call to avoid leaks.
>
> Alright... C++ exceptions are a minefield. :)
>
On 2015-06-09 22:52, Francisco Jerez wrote:
+
+ if (blocking)
+ hev().wait();
+
hard_event::wait() may fail, so this should probably be done before the
ret_object() call to avoid leaks.
Alright... C++ exceptions are a minefield. :)
Is there any reason you didn't make
the same change
Hi Grigori,
Grigori Goronzy writes:
> Wrap MapBuffer and MapImage as hard_event actions, like other
> operations. This enables correct profiling. Also make sure to wait
> for events to finish when blocking is requested by the caller.
> ---
> src/gallium/state_trackers/clover/api/transfer.cpp |
cc Francisco
On Thu, May 28, 2015 at 10:10:19AM +0200, Grigori Goronzy wrote:
> Wrap MapBuffer and MapImage as hard_event actions, like other
> operations. This enables correct profiling. Also make sure to wait
> for events to finish when blocking is requested by the caller.
> ---
> src/gallium/s
On 28.05.2015 10:10, Grigori Goronzy wrote:
> Wrap MapBuffer and MapImage as hard_event actions, like other
> operations. This enables correct profiling. Also make sure to wait
> for events to finish when blocking is requested by the caller.
> ---
Ping?
> src/gallium/state_trackers/clover/api/tr
Wrap MapBuffer and MapImage as hard_event actions, like other
operations. This enables correct profiling. Also make sure to wait
for events to finish when blocking is requested by the caller.
---
src/gallium/state_trackers/clover/api/transfer.cpp | 50 --
1 file changed, 46 ins
