Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Lionel Landwerlin
Thanks Eric & Tapani. Pushed to master. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Eric Engestrom
On Tuesday, 2018-11-06 12:55:06 +, Lionel Landwerlin wrote: > On 06/11/2018 12:52, Eric Engestrom wrote: > > On Tuesday, 2018-11-06 12:42:20 +, Lionel Landwerlin wrote: > > > On 06/11/2018 12:20, Eric Engestrom wrote: > > > > On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote: >

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Lionel Landwerlin
On 06/11/2018 12:52, Eric Engestrom wrote: On Tuesday, 2018-11-06 12:42:20 +, Lionel Landwerlin wrote: On 06/11/2018 12:20, Eric Engestrom wrote: On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote: This reduces the amount of #ifdef ANDROID we'll have to have inside the driver.

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Eric Engestrom
On Tuesday, 2018-11-06 12:42:20 +, Lionel Landwerlin wrote: > On 06/11/2018 12:20, Eric Engestrom wrote: > > On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote: > > > This reduces the amount of #ifdef ANDROID we'll have to have inside > > > the driver. Potentially offering better co

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Lionel Landwerlin
On 06/11/2018 12:20, Eric Engestrom wrote: On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote: This reduces the amount of #ifdef ANDROID we'll have to have inside the driver. Potentially offering better coverage of the android extensions. Signed-off-by: Lionel Landwerlin --- src/

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Eric Engestrom
On Tuesday, 2018-11-06 11:37:50 +, Lionel Landwerlin wrote: > This reduces the amount of #ifdef ANDROID we'll have to have inside > the driver. Potentially offering better coverage of the android > extensions. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/Makefile.sources

Re: [Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Tapani Pälli
Hi; This is very nice as when we get more Android functions it will reduce ifdeffing. This did not quite work though, but I found a cure! See below ... On 11/6/18 1:37 PM, Lionel Landwerlin wrote: This reduces the amount of #ifdef ANDROID we'll have to have inside the driver. Potentially off

[Mesa-dev] [PATCH 1/2] anv: stub internal android code

2018-11-06 Thread Lionel Landwerlin
This reduces the amount of #ifdef ANDROID we'll have to have inside the driver. Potentially offering better coverage of the android extensions. Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.sources | 4 +++ src/intel/Makefile.vulkan.am | 3 ++- src/intel/vulkan/anv_