Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

2016-10-06 Thread Jason Ekstrand
On Thu, Oct 6, 2016 at 1:33 PM, Nanley Chery wrote: > On Thu, Oct 06, 2016 at 12:35:53PM -0700, Jason Ekstrand wrote: > > On Thu, Oct 6, 2016 at 12:30 PM, Nanley Chery > wrote: > > > > > On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand wrote: > > > > Initially, we had intended set_subpas

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

2016-10-06 Thread Nanley Chery
On Thu, Oct 06, 2016 at 12:35:53PM -0700, Jason Ekstrand wrote: > On Thu, Oct 6, 2016 at 12:30 PM, Nanley Chery wrote: > > > On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand wrote: > > > Initially, we had intended set_subpass to be an interesting function that > > > did whatever (presumab

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

2016-10-06 Thread Jason Ekstrand
On Thu, Oct 6, 2016 at 12:30 PM, Nanley Chery wrote: > On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand wrote: > > Initially, we had intended set_subpass to be an interesting function that > > did whatever (presumably a lot) setup we needed for a subpass. In > reality, > > it just sets a

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

2016-10-06 Thread Nanley Chery
On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand wrote: > Initially, we had intended set_subpass to be an interesting function that > did whatever (presumably a lot) setup we needed for a subpass. In reality, > it just sets a pointer and a dirty bit and then emits depth and stencil > state

[Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

2016-10-05 Thread Jason Ekstrand
Initially, we had intended set_subpass to be an interesting function that did whatever (presumably a lot) setup we needed for a subpass. In reality, it just sets a pointer and a dirty bit and then emits depth and stencil state. When we call BeginCommandBuffer on a secondary, all of the dirty bits