Re: [Mesa-dev] [PATCH 1/2] Fix gcc version checks for _mesa_bitcount

2011-10-21 Thread Ian Romanick
On 10/21/2011 04:10 PM, Alan Coopersmith wrote: - Fix _GNUC__ typo in both checks - Fix logic error in check for gcc< 3.4 that breaks for gcc 2.x& older Without this fix, builds with gcc 3.4.x end up depending on undefined _mesa_bitcount instead of gcc's __builtin_popcount. NOTE: This is a ca

Re: [Mesa-dev] [PATCH 1/2] Fix gcc version checks for _mesa_bitcount

2011-10-21 Thread Kenneth Graunke
On 10/21/2011 04:10 PM, Alan Coopersmith wrote: > - Fix _GNUC__ typo in both checks > - Fix logic error in check for gcc < 3.4 that breaks for gcc 2.x & older > > Without this fix, builds with gcc 3.4.x end up depending on undefined > _mesa_bitcount instead of gcc's __builtin_popcount. > > NOTE:

[Mesa-dev] [PATCH 1/2] Fix gcc version checks for _mesa_bitcount

2011-10-21 Thread Alan Coopersmith
- Fix _GNUC__ typo in both checks - Fix logic error in check for gcc < 3.4 that breaks for gcc 2.x & older Without this fix, builds with gcc 3.4.x end up depending on undefined _mesa_bitcount instead of gcc's __builtin_popcount. NOTE: This is a candidate for the stable branches. Signed-off-by: A