Re: [Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name for radeon

2017-07-04 Thread Samuel Li
Note, this change depends on a libdrm change, which is also under review. Sam On 2017-07-04 05:35 PM, Samuel Li wrote: > Change-Id: I98d17f4af07c30f1739b43db1a6e1616a58332ef > Signed-off-by: Samuel Li > --- > src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 17 + > 1 file cha

[Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name for radeon

2017-07-04 Thread Samuel Li
Change-Id: I98d17f4af07c30f1739b43db1a6e1616a58332ef Signed-off-by: Samuel Li --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c b/src/gallium/winsys/radeon/drm/radeon_drm_

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name

2017-05-04 Thread Nicolai Hähnle
On 04.05.2017 14:08, Emil Velikov wrote: On 4 May 2017 at 12:12, Nicolai Hähnle wrote: On 03.05.2017 18:59, Li, Samuel wrote: Thanks for the comments. I was thinking probably marketing names only make sense for amdgpu, but I am OK to add a pointer to radeon_winsys. Will send a v2 later. We

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name

2017-05-04 Thread Emil Velikov
On 4 May 2017 at 12:12, Nicolai Hähnle wrote: > On 03.05.2017 18:59, Li, Samuel wrote: >> >> Thanks for the comments. I was thinking probably marketing names only make >> sense for amdgpu, but I am OK to add a pointer to radeon_winsys. Will send a >> v2 later. > > > We won't have marketing names w

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name

2017-05-04 Thread Nicolai Hähnle
H 1/1] radeonsi: Use libdrm to get chipset name Hi Sam, Please use git send-email in the future, it doesn't mess up the formatting :) This is generally not how we do winsys things, because radeon needs to be supported in addition to amdgpu. The usual approach is to add a new callback functi

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name

2017-05-03 Thread Li, Samuel
, Samuel ; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name Hi Sam, Please use git send-email in the future, it doesn't mess up the formatting :) This is generally not how we do winsys things, because radeon needs to be supported in add

Re: [Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name

2017-05-03 Thread Nicolai Hähnle
Hi Sam, Please use git send-email in the future, it doesn't mess up the formatting :) This is generally not how we do winsys things, because radeon needs to be supported in addition to amdgpu. The usual approach is to add a new callback function pointer to struct radeon_winsys, in this case

[Mesa-dev] [PATCH 1/1] radeonsi: Use libdrm to get chipset name

2017-05-02 Thread Li, Samuel
>From f097509a17a6ddf6a0f40fb1b73f289227a9539a Mon Sep 17 00:00:00 2001 From: Samuel Li Date: Thu, 27 Apr 2017 13:45:24 -0400 Subject: [PATCH 1/1] radeonsi: Use libdrm to get chipset name Change-Id: I614ea71424f9e5c97e4ae68654315d28c89eaa5f Signed-off-by: Samuel Li --- src/gallium/drivers/radeon