Re: [Mesa-dev] [PATCH 09/12] glcpp: Avoid unnecessary linear_strdup

2017-01-18 Thread Ian Romanick
On 01/07/2017 11:02 AM, Vladislav Egorov wrote: > The lexer copies every identifier it finds. At first look it seems > needless, because all these identifiers are already available stored > inside of shader text, but my experiments with immutable explicitly > sized strings (ptr, len) resulted in a

[Mesa-dev] [PATCH 09/12] glcpp: Avoid unnecessary linear_strdup

2017-01-07 Thread Vladislav Egorov
The lexer copies every identifier it finds. At first look it seems needless, because all these identifiers are already available stored inside of shader text, but my experiments with immutable explicitly sized strings (ptr, len) resulted in a lot of code change and didn't result in any speed increa