Re: [Mesa-dev] [PATCH 09/11] panfrost: Fix two uninitialized accesses in compiler

2019-05-09 Thread Emil Velikov
On Thu, 9 May 2019 at 07:35, Tomeu Vizoso wrote: > > Valgrind was complaining of those. > > NIR_PASS only sets progress to TRUE if there was progress. > > nir_const_load_to_arr() only sets as many constants as components has > the instruction. > > This was causing some dEQP tests to flip-flop, suc

[Mesa-dev] [PATCH 09/11] panfrost: Fix two uninitialized accesses in compiler

2019-05-08 Thread Tomeu Vizoso
Valgrind was complaining of those. NIR_PASS only sets progress to TRUE if there was progress. nir_const_load_to_arr() only sets as many constants as components has the instruction. This was causing some dEQP tests to flip-flop, such as: dEQP-GLES2.functional.fragment_ops.blend.equation_src_func