Re: [Mesa-dev] [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug

2015-10-19 Thread Brian Paul
On 10/18/2015 03:06 PM, Sinclair Yeh wrote: On Fri, Oct 16, 2015 at 03:25:16PM -0600, Brian Paul wrote: When long GL_LINE_LOOP primitives don't fit in one vertex buffer they have to be split across buffers. The code to do this was basically correct but drivers had to pay special attention to th

Re: [Mesa-dev] [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug

2015-10-18 Thread Brian Paul
On 10/17/2015 07:31 PM, Charmaine Lee wrote: From: Brian Paul Sent: Friday, October 16, 2015 2:25 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Jose Fonseca; Sinclair Yeh Subject: [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug When long GL_LINE_LOOP primitives don't fit in on

Re: [Mesa-dev] [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug

2015-10-18 Thread Sinclair Yeh
On Fri, Oct 16, 2015 at 03:25:16PM -0600, Brian Paul wrote: > When long GL_LINE_LOOP primitives don't fit in one vertex buffer they > have to be split across buffers. The code to do this was basically correct > but drivers had to pay special attention to the _mesa_prim::begin,end flags > in order

Re: [Mesa-dev] [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug

2015-10-17 Thread Charmaine Lee
>From: Brian Paul >Sent: Friday, October 16, 2015 2:25 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Jose Fonseca; Sinclair Yeh >Subject: [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug >When long GL_LINE_LOOP primitives don't fit in one vertex buffer they >have to be split acros

Re: [Mesa-dev] [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug

2015-10-17 Thread Brian Paul
On 10/17/2015 06:20 AM, Roland Scheidegger wrote: FWIW this probably fixes https://bugs.freedesktop.org/show_bug.cgi?id=49779 and https://bugs.freedesktop.org/show_bug.cgi?id=28130 (in contrast to 81174 which as you noted suffers both from a vbo and draw issue). (I believe the issue in draw is pr

Re: [Mesa-dev] [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug

2015-10-17 Thread Roland Scheidegger
FWIW this probably fixes https://bugs.freedesktop.org/show_bug.cgi?id=49779 and https://bugs.freedesktop.org/show_bug.cgi?id=28130 (in contrast to 81174 which as you noted suffers both from a vbo and draw issue). (I believe the issue in draw is pretty much the same, since things are split with too

[Mesa-dev] [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug

2015-10-16 Thread Brian Paul
When long GL_LINE_LOOP primitives don't fit in one vertex buffer they have to be split across buffers. The code to do this was basically correct but drivers had to pay special attention to the _mesa_prim::begin,end flags in order to draw the sections of the line loop properly. Apparently, the onl