Re: [Mesa-dev] [PATCH 09/10] mesa: Factor out struct gl_vertex_format.

2018-11-19 Thread Mathias Fröhlich
Hi Brian, On Sunday, 18 November 2018 20:54:50 CET Brian Paul wrote: > The series looks great. Just a few minor things below. > > Reviewed-by: Brian Paul Thank you! For reference, the requested changes in the following mail. I have also used GLubyte for Patch #10 then. best Mathias

[Mesa-dev] [PATCH 09/10] mesa: Factor out struct gl_vertex_format.

2018-11-19 Thread Mathias . Froehlich
From: Mathias Fröhlich Factor out struct gl_vertex_format from array attributes. The data type is supposed to describe the type of a vertex element. At this current stage the data type is only used with the VAO, but actually is useful in various other places. Due to the bitfields being used, spec

Re: [Mesa-dev] [PATCH 09/10] mesa: Factor out struct gl_vertex_format.

2018-11-18 Thread Brian Paul
The series looks great. Just a few minor things below. Reviewed-by: Brian Paul On 11/17/2018 05:14 AM, mathias.froehl...@gmx.net wrote: > From: Mathias Fröhlich > > Factor out struct gl_vertex_format from array attributes. > The data type is supposed to describe the type of a vertex > elemen

[Mesa-dev] [PATCH 09/10] mesa: Factor out struct gl_vertex_format.

2018-11-17 Thread Mathias . Froehlich
From: Mathias Fröhlich Factor out struct gl_vertex_format from array attributes. The data type is supposed to describe the type of a vertex element. At this current stage the data type is only used with the VAO, but actually is useful in various other places. Due to the bitfields being used, spec