Re: [Mesa-dev] [PATCH 09/10] i965: Add and use is_scheduling_barrier() function.

2016-03-09 Thread Francisco Jerez
Ian Romanick writes: > On 03/08/2016 04:47 PM, Francisco Jerez wrote: >> Matt Turner writes: >> >>> On Fri, Mar 4, 2016 at 8:49 PM, Francisco Jerez >>> wrote: Matt Turner writes: > Though there is a lot of overlap with has_side_effects(), these do mean > different things. >

Re: [Mesa-dev] [PATCH 09/10] i965: Add and use is_scheduling_barrier() function.

2016-03-08 Thread Ian Romanick
On 03/08/2016 04:47 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Fri, Mar 4, 2016 at 8:49 PM, Francisco Jerez >> wrote: >>> Matt Turner writes: >>> Though there is a lot of overlap with has_side_effects(), these do mean different things. >>> >>> Can we do it the other way

Re: [Mesa-dev] [PATCH 09/10] i965: Add and use is_scheduling_barrier() function.

2016-03-08 Thread Francisco Jerez
Matt Turner writes: > On Fri, Mar 4, 2016 at 8:49 PM, Francisco Jerez wrote: >> Matt Turner writes: >> >>> Though there is a lot of overlap with has_side_effects(), these do mean >>> different things. >> >> Can we do it the other way around and implement is_scheduling_barrier() >> in terms of h

Re: [Mesa-dev] [PATCH 09/10] i965: Add and use is_scheduling_barrier() function.

2016-03-08 Thread Matt Turner
On Fri, Mar 4, 2016 at 8:49 PM, Francisco Jerez wrote: > Matt Turner writes: > >> Though there is a lot of overlap with has_side_effects(), these do mean >> different things. > > Can we do it the other way around and implement is_scheduling_barrier() > in terms of has_side_effects()? has_side_ef

Re: [Mesa-dev] [PATCH 09/10] i965: Add and use is_scheduling_barrier() function.

2016-03-04 Thread Francisco Jerez
Matt Turner writes: > Though there is a lot of overlap with has_side_effects(), these do mean > different things. Can we do it the other way around and implement is_scheduling_barrier() in terms of has_side_effects()? has_side_effects() seems like the more fundamental of the two and because is_

[Mesa-dev] [PATCH 09/10] i965: Add and use is_scheduling_barrier() function.

2016-03-04 Thread Matt Turner
Though there is a lot of overlap with has_side_effects(), these do mean different things. --- src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 6 ++ src/mesa/drivers/dri/i965/brw_shader.cpp| 12 +++- src/mesa/drivers/dri/i965/brw_shader.h | 2