Re: [Mesa-dev] [PATCH 08/13] nir: add control flow helpers for loop unrolling

2016-08-29 Thread Connor Abbott
On Mon, Aug 29, 2016 at 11:57 PM, Timothy Arceri wrote: > On Mon, 2016-08-29 at 20:42 -0400, Connor Abbott wrote: >> I already noted in patch 12/13 that you can get rid of your use of >> stitch_blocks(). I also don't get why you need a special >> nir_cf_loop_list_extract() here... why >> >> On Mon

Re: [Mesa-dev] [PATCH 08/13] nir: add control flow helpers for loop unrolling

2016-08-29 Thread Timothy Arceri
On Mon, 2016-08-29 at 20:42 -0400, Connor Abbott wrote: > I already noted in patch 12/13 that you can get rid of your use of > stitch_blocks(). I also don't get why you need a special > nir_cf_loop_list_extract() here... why > > On Mon, Aug 29, 2016 at 12:59 AM, Timothy Arceri > wrote: > > > > T

Re: [Mesa-dev] [PATCH 08/13] nir: add control flow helpers for loop unrolling

2016-08-29 Thread Connor Abbott
I already noted in patch 12/13 that you can get rid of your use of stitch_blocks(). I also don't get why you need a special nir_cf_loop_list_extract() here... why On Mon, Aug 29, 2016 at 12:59 AM, Timothy Arceri wrote: > This makes stitch_blocks() available for use else where, and adds > a new he

[Mesa-dev] [PATCH 08/13] nir: add control flow helpers for loop unrolling

2016-08-28 Thread Timothy Arceri
This makes stitch_blocks() available for use else where, and adds a new helper that extracts a cf list without worrying about validation. --- src/compiler/nir/nir_control_flow.c | 34 -- src/compiler/nir/nir_control_flow.h | 5 + 2 files changed, 37 insertions(