Re: [Mesa-dev] [PATCH 08/12] mesa: Fix incorrect access parameter passed to MapBuffer

2011-08-22 Thread Eric Anholt
On Mon, 22 Aug 2011 00:33:00 -0700, "Ian Romanick" wrote: > From: Ian Romanick > > The code previously passed GL_DYNAMIC_DRAW for the access parameter. > By inspection, I believe that all drivers would treat this as > GL_READ_WRITE because it's not GL_READ_ONLY and it's not > GL_WRITE_ONLY. How

Re: [Mesa-dev] [PATCH 08/12] mesa: Fix incorrect access parameter passed to MapBuffer

2011-08-22 Thread Keith Whitwell
Your analysis sounds reasonable to me, Ian. Looks good. Keith On Mon, 2011-08-22 at 00:33 -0700, Ian Romanick wrote: > From: Ian Romanick > > The code previously passed GL_DYNAMIC_DRAW for the access parameter. > By inspection, I believe that all drivers would treat this as > GL_READ_WRITE bec

[Mesa-dev] [PATCH 08/12] mesa: Fix incorrect access parameter passed to MapBuffer

2011-08-22 Thread Ian Romanick
From: Ian Romanick The code previously passed GL_DYNAMIC_DRAW for the access parameter. By inspection, I believe that all drivers would treat this as GL_READ_WRITE because it's not GL_READ_ONLY and it's not GL_WRITE_ONLY. However, my guess is that this code actually wants to use GL_WRITE_ONLY.