Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-07 Thread Jason Ekstrand
On Fri, Aug 4, 2017 at 1:08 PM, Jordan Justen wrote: > On 2017-08-02 13:35:33, Jason Ekstrand wrote: > > Originally, I had moved it to the caller to make some things easier when > > adding the CCS modifier. However, this broke DRI2 because > > intel_process_dri2_buffer calls intel_miptree_create

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-04 Thread Jordan Justen
On 2017-08-02 13:35:33, Jason Ekstrand wrote: > Originally, I had moved it to the caller to make some things easier when > adding the CCS modifier. However, this broke DRI2 because > intel_process_dri2_buffer calls intel_miptree_create_for_bo but never > calls intel_miptree_alloc_aux. Also, in hi

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Tapani Pälli
On 08/03/2017 09:33 AM, Tapani Pälli wrote: On 08/03/2017 09:28 AM, Jason Ekstrand wrote: On August 2, 2017 11:21:33 PM Tapani Pälli wrote: Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on bot

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Tapani Pälli
On 08/03/2017 09:28 AM, Jason Ekstrand wrote: On August 2, 2017 11:21:33 PM Tapani Pälli wrote: Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on both. Can you provide a but now detail? I tried

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Jason Ekstrand
On August 2, 2017 11:21:33 PM Tapani Pälli wrote: Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on both. Can you provide a but now detail? I tried today but wasn't able to reproduce the piglit fa

Re: [Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Tapani Pälli
Hi Jason; Unfortunately this patch does not fix the mentioned bug. I've tested both with Piglit on desktop and on Android and issue persists on both. On 08/02/2017 11:35 PM, Jason Ekstrand wrote: Originally, I had moved it to the caller to make some things easier when adding the CCS modifier

[Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

2017-08-02 Thread Jason Ekstrand
Originally, I had moved it to the caller to make some things easier when adding the CCS modifier. However, this broke DRI2 because intel_process_dri2_buffer calls intel_miptree_create_for_bo but never calls intel_miptree_alloc_aux. Also, in hindsight, it should be pretty easy to make the CCS modi