On Fri, 2016-12-09 at 17:23 -0800, Jason Ekstrand wrote:
> Wow! This is way better than the last time I read through it. Good
> work!
>
> Overall, I'm much happier with the code now. The structure is
> better, some of the crazy phi logic is gone, and clone_cf_list is
> helping a lot. That said
Wow! This is way better than the last time I read through it. Good work!
Overall, I'm much happier with the code now. The structure is better, some
of the crazy phi logic is gone, and clone_cf_list is helping a lot. That
said... I still have a pile of comments. Most of them are cosmetic, one
V2:
- tidy ups suggested by Connor.
- tidy up cloning logic and handle copy propagation
based of suggestion by Connor.
- use nir_ssa_def_rewrite_uses to fix up lcssa phis
suggested by Connor.
- add support for complex loop unrolling (two terminators)
- handle case were the ssa defs use outside t
On Thu, 2016-10-06 at 10:33 -0700, Jason Ekstrand wrote:
> >
> > On Wed, Oct 5, 2016 at 7:25 PM, Timothy Arceri > abora.com> wrote:
> > > Just
> > >
> > > On Wed, 2016-10-05 at 16:23 -0700, Jason Ekstrand wrote:
> > > >
> > > >
> > > > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri > > i@col
On Thu, Oct 6, 2016 at 10:22 AM, Jason Ekstrand
wrote:
>
>
> On Wed, Oct 5, 2016 at 7:25 PM, Timothy Arceri <
> timothy.arc...@collabora.com> wrote:
>
>> Just
>>
>> On Wed, 2016-10-05 at 16:23 -0700, Jason Ekstrand wrote:
>> >
>> >
>> > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri > > abora.co
On Wed, Oct 5, 2016 at 7:25 PM, Timothy Arceri wrote:
> Just
>
> On Wed, 2016-10-05 at 16:23 -0700, Jason Ekstrand wrote:
> >
> >
> > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri > abora.com> wrote:
> > > V2:
> > > - tidy ups suggested by Connor.
> > > - tidy up cloning logic and handle copy
On Thu, 2016-10-06 at 13:25 +1100, Timothy Arceri wrote:
> > > +
> > > +static void
> > > +update_remap_tables(bool is_first_iteration, struct hash_table
> > > *remap_table,
> > > + struct hash_table *phi_remap,
> > > + struct hash_table *src_before_loop,
>
Just
On Wed, 2016-10-05 at 16:23 -0700, Jason Ekstrand wrote:
>
>
> On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri abora.com> wrote:
> > V2:
> > - tidy ups suggested by Connor.
> > - tidy up cloning logic and handle copy propagation
> > based of suggestion by Connor.
> > - use nir_ssa_def_r
On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri <
timothy.arc...@collabora.com> wrote:
> V2:
> - tidy ups suggested by Connor.
> - tidy up cloning logic and handle copy propagation
> based of suggestion by Connor.
> - use nir_ssa_def_rewrite_uses to fix up lcssa phis
> suggested by Connor.
> -
V2:
- tidy ups suggested by Connor.
- tidy up cloning logic and handle copy propagation
based of suggestion by Connor.
- use nir_ssa_def_rewrite_uses to fix up lcssa phis
suggested by Connor.
- add support for complex loop unrolling (two terminators)
- handle case were the ssa defs use outside t
10 matches
Mail list logo
