Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-18 Thread Emil Velikov
On 17 February 2016 at 22:43, Rob Clark wrote: > On Wed, Feb 17, 2016 at 4:40 PM, Patrick Baggett > wrote: >> On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark wrote: >>> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >>> {anonymous}::lower_discard_flow_visitor::visit_enter

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
Thanks for running that thru CI.. if you have a chance, I wouldn't mind a review on v2 of 01/10 (since that one is by far the most noisy gcc6 warning, and would be nice to get that clean-up in before the branch point) BR, -R On Wed, Feb 17, 2016 at 8:43 PM, Ian Romanick wrote: > I ran this thr

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Ian Romanick
I ran this through our CI, and I didn't see any regressions cause by it. I think this is correct, so this patch is Reviewed-by: Ian Romanick On 02/17/2016 01:35 PM, Rob Clark wrote: > src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status > {anonymous}::lower_discard_flow_v

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
On Wed, Feb 17, 2016 at 4:40 PM, Patrick Baggett wrote: > On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> but not used [-Wunused-fun

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Patrick Baggett
On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark wrote: > src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status > {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined > but not used [-Wunused-function] > lower_discard_flow_visitor::visit_enter(ir_loop_jump

[Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined but not used [-Wunused-function] lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir) ^~ The base class method th

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-17 Thread Rob Clark
On Tue, Feb 16, 2016 at 2:32 PM, Ian Romanick wrote: > On 02/16/2016 10:58 AM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> but not used [-Wunused-function] >> lo

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
On Tue, Feb 16, 2016 at 2:32 PM, Ian Romanick wrote: > On 02/16/2016 10:58 AM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> but not used [-Wunused-function] >> lo

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Ian Romanick
On 02/16/2016 10:58 AM, Rob Clark wrote: > src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status > {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined > but not used [-Wunused-function] > lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir) > ^

[Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

2016-02-16 Thread Rob Clark
src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined but not used [-Wunused-function] lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir) ^~ Note, not sure if this w