Re: [Mesa-dev] [PATCH 07/16] radv: Implement VK_KHR_maintenance3.

2018-03-08 Thread Emil Velikov
On 7 March 2018 at 19:56, Emil Velikov wrote: > On 7 March 2018 at 18:32, Bas Nieuwenhuizen wrote: > >>> >>> Missing break? >> >> So much for the tests ... >> > Speaking of tests, I hope they check that both KHR and non KHR > annotated functions (the ones changed in 04/16) are tested. > We don't

Re: [Mesa-dev] [PATCH 07/16] radv: Implement VK_KHR_maintenance3.

2018-03-07 Thread Emil Velikov
On 7 March 2018 at 18:32, Bas Nieuwenhuizen wrote: >> >> Missing break? > > So much for the tests ... > Speaking of tests, I hope they check that both KHR and non KHR annotated functions (the ones changed in 04/16) are tested. We don't want them to disappear for setups using a pre 1.1 loader. Ju

Re: [Mesa-dev] [PATCH 07/16] radv: Implement VK_KHR_maintenance3.

2018-03-07 Thread Samuel Pitoiset
On 03/07/2018 07:32 PM, Bas Nieuwenhuizen wrote: On Wed, Mar 7, 2018 at 7:19 PM, Samuel Pitoiset wrote: On 03/07/2018 03:47 PM, Bas Nieuwenhuizen wrote: Reviewed-by: Dave Airlie --- src/amd/vulkan/radv_descriptor_set.c | 82 ++-- src/amd/vulkan/radv_d

Re: [Mesa-dev] [PATCH 07/16] radv: Implement VK_KHR_maintenance3.

2018-03-07 Thread Bas Nieuwenhuizen
On Wed, Mar 7, 2018 at 7:19 PM, Samuel Pitoiset wrote: > > > On 03/07/2018 03:47 PM, Bas Nieuwenhuizen wrote: >> >> Reviewed-by: Dave Airlie >> --- >> src/amd/vulkan/radv_descriptor_set.c | 82 >> ++-- >> src/amd/vulkan/radv_device.c | 10 + >> src/

Re: [Mesa-dev] [PATCH 07/16] radv: Implement VK_KHR_maintenance3.

2018-03-07 Thread Samuel Pitoiset
On 03/07/2018 03:47 PM, Bas Nieuwenhuizen wrote: Reviewed-by: Dave Airlie --- src/amd/vulkan/radv_descriptor_set.c | 82 ++-- src/amd/vulkan/radv_device.c | 10 + src/amd/vulkan/radv_extensions.py| 1 + 3 files changed, 89 insertions(+), 4

Re: [Mesa-dev] [PATCH 07/16] radv: Implement VK_KHR_maintenance3.

2018-03-07 Thread Gustaw Smolarczyk
2018-03-07 15:47 GMT+01:00 Bas Nieuwenhuizen : > Reviewed-by: Dave Airlie > --- > src/amd/vulkan/radv_descriptor_set.c | 82 ++ > -- > src/amd/vulkan/radv_device.c | 10 + > src/amd/vulkan/radv_extensions.py| 1 + > 3 files changed, 89 insertions(

[Mesa-dev] [PATCH 07/16] radv: Implement VK_KHR_maintenance3.

2018-03-07 Thread Bas Nieuwenhuizen
Reviewed-by: Dave Airlie --- src/amd/vulkan/radv_descriptor_set.c | 82 ++-- src/amd/vulkan/radv_device.c | 10 + src/amd/vulkan/radv_extensions.py| 1 + 3 files changed, 89 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_descriptor