Re: [Mesa-dev] [PATCH 07/11] glsl: add double support

2014-08-24 Thread Dave Airlie
On 23 August 2014 10:43, Ian Romanick wrote: > There is a handful of minor comments below. > > There is one additional thing missing: handling doubles in UBOs. Many > places in the linker (a bunch of which I just changed) assume, for > alignment purposes, that every basic type is 4-bytes. Severa

Re: [Mesa-dev] [PATCH 07/11] glsl: add double support

2014-08-22 Thread Ian Romanick
There is a handful of minor comments below. There is one additional thing missing: handling doubles in UBOs. Many places in the linker (a bunch of which I just changed) assume, for alignment purposes, that every basic type is 4-bytes. Several places in the std140 packing rules say things like ".

Re: [Mesa-dev] [PATCH 07/11] glsl: add double support

2014-08-19 Thread Pohjolainen, Topi
On Thu, Aug 14, 2014 at 08:52:38PM +1000, Dave Airlie wrote: > This adds the guts of the fp64 implementation to the GLSL compiler. > > - builtin double types > - double constant support > - lexer parsing for double types (lf, LF) > - enforcing flat on double fs inputs > - double operations (d2f,f2

[Mesa-dev] [PATCH 07/11] glsl: add double support

2014-08-14 Thread Dave Airlie
This adds the guts of the fp64 implementation to the GLSL compiler. - builtin double types - double constant support - lexer parsing for double types (lf, LF) - enforcing flat on double fs inputs - double operations (d2f,f2d, pack/unpack, frexp - in 2 parts) - ir builder bits. - double constant ex