Re: [Mesa-dev] [PATCH 060/133] nir: Validate all lists in the validator

2014-12-17 Thread Connor Abbott
On Wed, Dec 17, 2014 at 8:00 PM, Jason Ekstrand wrote: > > > On Wed, Dec 17, 2014 at 4:52 PM, Connor Abbott wrote: >> >> I think we're missing a few things: >> >> * Phi node sources > > > Added > >> >> * Parallel copy entries > > > I don't think we're validating anything for parallel copies right

Re: [Mesa-dev] [PATCH 060/133] nir: Validate all lists in the validator

2014-12-17 Thread Jason Ekstrand
On Wed, Dec 17, 2014 at 4:52 PM, Connor Abbott wrote: > > I think we're missing a few things: > > * Phi node sources > Added > * Parallel copy entries > I don't think we're validating anything for parallel copies right now. It would be nice to, but there's no real good way to do so since they

Re: [Mesa-dev] [PATCH 060/133] nir: Validate all lists in the validator

2014-12-17 Thread Connor Abbott
I think we're missing a few things: * Phi node sources * Parallel copy entries Whether you care enough to validate those is up to you. Otherwise Reviewed-by: Connor Abbott On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_validate.c | 13 + > 1 file

[Mesa-dev] [PATCH 060/133] nir: Validate all lists in the validator

2014-12-15 Thread Jason Ekstrand
--- src/glsl/nir/nir_validate.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index 200c85a..ae8deb8 100644 --- a/src/glsl/nir/nir_validate.c +++ b/src/glsl/nir/nir_validate.c @@ -452,6 +452,7 @@ validate_phi_src(nir_ph