Re: [Mesa-dev] [PATCH 06/37] util: add a disk_cache_remove() function

2017-01-24 Thread Timothy Arceri
On Tue, 2017-01-24 at 17:38 -0800, Eric Anholt wrote: > Timothy Arceri writes: > > > On Tue, 2017-01-24 at 15:54 -0800, Eric Anholt wrote: > > > Timothy Arceri writes: > > > > > > > From: Timothy Arceri > > > > > > > > This will be used to remove cache items created with old > > > > versions

Re: [Mesa-dev] [PATCH 06/37] util: add a disk_cache_remove() function

2017-01-24 Thread Eric Anholt
Timothy Arceri writes: > On Tue, 2017-01-24 at 15:54 -0800, Eric Anholt wrote: >> Timothy Arceri writes: >> >> > From: Timothy Arceri >> > >> > This will be used to remove cache items created with old versions >> > of Mesa or other invalid cache items from the cache. >> >> I'm not convinced

Re: [Mesa-dev] [PATCH 06/37] util: add a disk_cache_remove() function

2017-01-24 Thread Timothy Arceri
On Tue, 2017-01-24 at 15:54 -0800, Eric Anholt wrote: > Timothy Arceri writes: > > > From: Timothy Arceri > > > > This will be used to remove cache items created with old versions > > of Mesa or other invalid cache items from the cache. > > I'm not convinced that removing the item from cache w

Re: [Mesa-dev] [PATCH 06/37] util: add a disk_cache_remove() function

2017-01-24 Thread Eric Anholt
Timothy Arceri writes: > From: Timothy Arceri > > This will be used to remove cache items created with old versions > of Mesa or other invalid cache items from the cache. I'm not convinced that removing the item from cache when we get a hit on everything in the key except for Mesa version is th

Re: [Mesa-dev] [PATCH 06/37] util: add a disk_cache_remove() function

2017-01-23 Thread Timothy Arceri
Apologies if you are wondering where this is used. This patch really should be before patch 24. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 06/37] util: add a disk_cache_remove() function

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This will be used to remove cache items created with old versions of Mesa or other invalid cache items from the cache. --- src/util/disk_cache.c | 22 ++ src/util/disk_cache.h | 12 2 files changed, 34 insertions(+) diff --git a/src/util/dis