Re: [Mesa-dev] [PATCH 06/31] nir/search: Use nir_builder

2018-10-22 Thread Jason Ekstrand
On Mon, Oct 22, 2018 at 5:50 PM Ian Romanick wrote: > I think a better description is "nir/search: Use nir_imm_* helpers". > Using nir_builder is just a prerequisite to doing that. > Good call. The new commit message is: nir/search: Use the nir_imm_* helpers from nir_builder This requ

Re: [Mesa-dev] [PATCH 06/31] nir/search: Use nir_builder

2018-10-22 Thread Ian Romanick
I think a better description is "nir/search: Use nir_imm_* helpers". Using nir_builder is just a prerequisite to doing that. On 10/22/2018 03:13 PM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_algebraic.py | 14 ++-- > src/compiler/nir/nir_search.c | 111 --

[Mesa-dev] [PATCH 06/31] nir/search: Use nir_builder

2018-10-22 Thread Jason Ekstrand
--- src/compiler/nir/nir_algebraic.py | 14 ++-- src/compiler/nir/nir_search.c | 111 -- src/compiler/nir/nir_search.h | 9 ++- 3 files changed, 43 insertions(+), 91 deletions(-) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebrai