Re: [Mesa-dev] [PATCH 06/13] mesa: Replace sampler object locks with atomic inc/dec.

2015-09-25 Thread Matt Turner
On Mon, Aug 10, 2015 at 9:16 AM, Matt Turner wrote: > On Fri, Aug 7, 2015 at 10:09 AM, Ian Romanick wrote: >> I know we've talked about this about 100 times, but something in the >> back of my mind tells me that we have a pre-existing race. What happens >> if the p_atomic_dec_zero happens on thr

Re: [Mesa-dev] [PATCH 06/13] mesa: Replace sampler object locks with atomic inc/dec.

2015-08-10 Thread Timothy Arceri
On Mon, 2015-08-10 at 09:16 -0700, Matt Turner wrote: > On Fri, Aug 7, 2015 at 10:09 AM, Ian Romanick wrote: > > I know we've talked about this about 100 times, but something in the > > back of my mind tells me that we have a pre-existing race. What happens > > if the p_atomic_dec_zero happens on

Re: [Mesa-dev] [PATCH 06/13] mesa: Replace sampler object locks with atomic inc/dec.

2015-08-10 Thread Matt Turner
On Fri, Aug 7, 2015 at 10:09 AM, Ian Romanick wrote: > I know we've talked about this about 100 times, but something in the > back of my mind tells me that we have a pre-existing race. What happens > if the p_atomic_dec_zero happens on thread A while thread B is between > the _mesa_lookup_renderb

Re: [Mesa-dev] [PATCH 06/13] mesa: Replace sampler object locks with atomic inc/dec.

2015-08-07 Thread Timothy Arceri
On Fri, 2015-08-07 at 10:09 -0700, Ian Romanick wrote: > I know we've talked about this about 100 times, but something in the > back of my mind tells me that we have a pre-existing race. What happens > if the p_atomic_dec_zero happens on thread A while thread B is between > the _mesa_lookup_render

Re: [Mesa-dev] [PATCH 06/13] mesa: Replace sampler object locks with atomic inc/dec.

2015-08-07 Thread Ian Romanick
I know we've talked about this about 100 times, but something in the back of my mind tells me that we have a pre-existing race. What happens if the p_atomic_dec_zero happens on thread A while thread B is between the _mesa_lookup_renderbuffer call and the _mesa_reference_renderbuffer call on the sa

[Mesa-dev] [PATCH 06/13] mesa: Replace sampler object locks with atomic inc/dec.

2015-08-06 Thread Matt Turner
--- src/mesa/main/mtypes.h | 1 - src/mesa/main/samplerobj.c | 16 +++- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 2adfae2..fcc527f 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -1153,