Re: [Mesa-dev] [PATCH 06/12] nir: don't count removal of lcssa_phi as progress

2016-08-27 Thread Timothy Arceri
On Sat, 2016-08-27 at 16:06 +0200, Thomas Helland wrote: > 2016-08-27 8:03 GMT+02:00 Timothy Arceri m>: > > > > We generate these in each optimisation pass, counting them > > as progress would cause the loop to run forever. > > These are just some random thoughts that I thought I'd share. > It m

Re: [Mesa-dev] [PATCH 06/12] nir: don't count removal of lcssa_phi as progress

2016-08-27 Thread Thomas Helland
2016-08-27 8:03 GMT+02:00 Timothy Arceri : > We generate these in each optimisation pass, counting them > as progress would cause the loop to run forever. These are just some random thoughts that I thought I'd share. It might not make sense at all, and it might be answered in the patch series, but

[Mesa-dev] [PATCH 06/12] nir: don't count removal of lcssa_phi as progress

2016-08-26 Thread Timothy Arceri
We generate these in each optimisation pass, counting them as progress would cause the loop to run forever. --- src/compiler/nir/nir_opt_remove_phis.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_opt_remove_phis.c b/src/compiler/nir/nir_opt_remove_phis.c index ee92f