Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-28 Thread Brian Paul
Superficial comments below. On 09/27/2015 12:33 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/mesa/Makefile.sources| 1 + src/mesa/program/ir_to_mesa.cpp | 4 +- src/mesa/state_tracker/st_atom.c | 5 + src/mesa/state_tracker/s

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Ilia Mirkin
On Sun, Sep 27, 2015 at 5:27 PM, Marek Olšák wrote: > On Sun, Sep 27, 2015 at 11:10 PM, Ilia Mirkin wrote: >> On Sun, Sep 27, 2015 at 2:48 PM, Marek Olšák wrote: >>> Patches 2-5 are: +static void st_bind_atomics(struct st_context *st, + struct gl_shader_progra

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Marek Olšák
On Sun, Sep 27, 2015 at 11:10 PM, Ilia Mirkin wrote: > On Sun, Sep 27, 2015 at 2:48 PM, Marek Olšák wrote: >> Patches 2-5 are: >>> +static void st_bind_atomics(struct st_context *st, >>> + struct gl_shader_program *prog, >>> + unsigned shader_ty

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Ilia Mirkin
On Sun, Sep 27, 2015 at 2:48 PM, Marek Olšák wrote: > Patches 2-5 are: > > Reviewed-by: Marek Olšák > > Same for patch 1 if you rename "RES" to "IMAGE". > > See below for patch 6 comments. > > On Sun, Sep 27, 2015 at 8:33 AM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/mesa/

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Marek Olšák
Patches 2-5 are: Reviewed-by: Marek Olšák Same for patch 1 if you rename "RES" to "IMAGE". See below for patch 6 comments. On Sun, Sep 27, 2015 at 8:33 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/Makefile.sources| 1 + > src/mesa/program/ir_to_

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Ilia Mirkin
On Sun, Sep 27, 2015 at 3:20 AM, Kai Wasserbäch wrote: > Ilia Mirkin wrote on 27.09.2015 08:33: >> Signed-off-by: Ilia Mirkin >> --- >> src/mesa/Makefile.sources| 1 + >> src/mesa/program/ir_to_mesa.cpp | 4 +- >> src/mesa/state_tracker/st_atom.c

Re: [Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-27 Thread Kai Wasserbäch
Ilia Mirkin wrote on 27.09.2015 08:33: > Signed-off-by: Ilia Mirkin > --- > src/mesa/Makefile.sources| 1 + > src/mesa/program/ir_to_mesa.cpp | 4 +- > src/mesa/state_tracker/st_atom.c | 5 + > src/mesa/state_tracker/st_atom.h | 5 +

[Mesa-dev] [PATCH 06/11] st/mesa: add atomic buffer support

2015-09-26 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/Makefile.sources| 1 + src/mesa/program/ir_to_mesa.cpp | 4 +- src/mesa/state_tracker/st_atom.c | 5 + src/mesa/state_tracker/st_atom.h | 5 + src/mesa/state_tracker/st_atom_atomicbuf.c | 15