Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

2017-06-28 Thread Wladimir J. van der Laan
> > Why do this copy if to==from? > > Tile-status resolve. We currently don't support sampler TS (which is Ah of course. Might make sense to add a comment mentioning this, it's not straightforward when reading the code :) > probably worth implementing, as it has potentially large performance >

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

2017-06-28 Thread Lucas Stach
Am Mittwoch, den 28.06.2017, 16:10 +0200 schrieb Lucas Stach: > Am Mittwoch, den 28.06.2017, 16:07 +0200 schrieb Wladimir J. van der > Laan: > > On Fri, Jun 23, 2017 at 05:50:23PM +0200, Lucas Stach wrote: > > > This reworks the logic in etna_update_sampler_source to select the > > > newest resourc

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

2017-06-28 Thread Lucas Stach
Am Mittwoch, den 28.06.2017, 16:07 +0200 schrieb Wladimir J. van der Laan: > On Fri, Jun 23, 2017 at 05:50:23PM +0200, Lucas Stach wrote: > > This reworks the logic in etna_update_sampler_source to select the > > newest resource view for updating the texture view. This should make > > the logic eas

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

2017-06-28 Thread Wladimir J. van der Laan
On Fri, Jun 23, 2017 at 05:50:23PM +0200, Lucas Stach wrote: > This reworks the logic in etna_update_sampler_source to select the > newest resource view for updating the texture view. This should make > the logic easier to follow and fixes texture updates from imported > dma-bufs. Comment in-line

Re: [Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

2017-06-26 Thread Philipp Zabel
On Fri, 2017-06-23 at 17:50 +0200, Lucas Stach wrote: > This reworks the logic in etna_update_sampler_source to select the > newest resource view for updating the texture view. This should make > the logic easier to follow and fixes texture updates from imported > dma-bufs. > > Signed-off-by: Luca

[Mesa-dev] [PATCH 06/11] etnaviv: also update textures from external resources

2017-06-23 Thread Lucas Stach
This reworks the logic in etna_update_sampler_source to select the newest resource view for updating the texture view. This should make the logic easier to follow and fixes texture updates from imported dma-bufs. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_texture.c | 23 +