Re: [Mesa-dev] [PATCH 06/11] compiler/blob: make blob_reserve_bytes() more useful

2017-10-12 Thread Jordan Justen
On 2017-10-11 13:38:46, Jason Ekstrand wrote: > From: Connor Abbott > > Despite the name, it could only be used if you immediately wrote to the > pointer. Noboby was using it outside of one test, so clearly this > behavior wasn't that useful. Instead, make it return an offset into the > data buff

Re: [Mesa-dev] [PATCH 06/11] compiler/blob: make blob_reserve_bytes() more useful

2017-10-11 Thread Nicolai Hähnle
On 11.10.2017 22:38, Jason Ekstrand wrote: From: Connor Abbott Despite the name, it could only be used if you immediately wrote to the pointer. Noboby was using it outside of one test, so clearly this behavior wasn't that useful. Instead, make it return an offset into the data buffer so that th

[Mesa-dev] [PATCH 06/11] compiler/blob: make blob_reserve_bytes() more useful

2017-10-11 Thread Jason Ekstrand
From: Connor Abbott Despite the name, it could only be used if you immediately wrote to the pointer. Noboby was using it outside of one test, so clearly this behavior wasn't that useful. Instead, make it return an offset into the data buffer so that the result isn't invalidated if you later write