Re: [Mesa-dev] [PATCH 057/133] nir: Add a better out-of-SSA pass

2014-12-17 Thread Jason Ekstrand
On Wed, Dec 17, 2014 at 3:30 PM, Connor Abbott wrote: > > Whew! Other than a few minor things below, > > Reviewed-by: Connor Abbott > > I tried to understand it all as much as I could, but it is rather > tricky... but I can't suggest anything to make it easier to > understand, after all the paper

Re: [Mesa-dev] [PATCH 057/133] nir: Add a better out-of-SSA pass

2014-12-17 Thread Connor Abbott
Whew! Other than a few minor things below, Reviewed-by: Connor Abbott I tried to understand it all as much as I could, but it is rather tricky... but I can't suggest anything to make it easier to understand, after all the paper itself is rather tricky and your comments help a lot. If anyone has

[Mesa-dev] [PATCH 057/133] nir: Add a better out-of-SSA pass

2014-12-15 Thread Jason Ekstrand
This commit rewrites the out-of-SSA pass to not be nearly as naieve. It's based on "Revisiting Out-of-SSA Translation for Correctness, Code Quality, and Efficiency" by Boissinot et. al. It should be fairly close to state-of-the art. --- src/glsl/nir/nir_from_ssa.c | 793 +