Re: [Mesa-dev] [PATCH 05/24] st/mesa: unify update_gp/tcp/tep code

2017-07-01 Thread Gert Wollny
Hello Marek, this patch makes most of the tesselation shaders in piglit crash because now you are passing MESA_SHADER_TESS_* to st_get_basic_variant, but this function tests for PIPE_SHADER_TESS_* when allocating new variants. Hence, the function doesn't fulfill the assert in debug mode, or it r

Re: [Mesa-dev] [PATCH 05/24] st/mesa: unify update_gp/tcp/tep code

2017-06-12 Thread Timothy Arceri
1-5: Reviewed-by: Timothy Arceri On 13/06/17 04:18, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atom_shader.c | 91 ++--- 1 file changed, 28 insertions(+), 63 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_shader.c b/src/mesa/

[Mesa-dev] [PATCH 05/24] st/mesa: unify update_gp/tcp/tep code

2017-06-12 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_atom_shader.c | 91 ++--- 1 file changed, 28 insertions(+), 63 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_shader.c b/src/mesa/state_tracker/st_atom_shader.c index b6b3222..c1869d3 100644 --- a/src/mesa/st