Re: [Mesa-dev] [PATCH 05/22] nir/spirv: cast shift operand to u32

2018-11-13 Thread Karol Herbst
yeah... I planned to push the first two patches some time ago. Simply forgot about those. On Tue, Nov 13, 2018 at 10:13 PM Jason Ekstrand wrote: > > Also, I don't see why this one and the first two can't land today. They're > obvious clean-ups. > > On Tue, Nov 13, 2018 at 3:11 PM Jason Ekstrand

Re: [Mesa-dev] [PATCH 05/22] nir/spirv: cast shift operand to u32

2018-11-13 Thread Jason Ekstrand
Also, I don't see why this one and the first two can't land today. They're obvious clean-ups. On Tue, Nov 13, 2018 at 3:11 PM Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > Cc: mesa-sta...@lists.freedesktop.org > > On Tue, Nov 13, 2018 at 9:48 AM Karol Herbst wrote: > >> v2: fix for sp

Re: [Mesa-dev] [PATCH 05/22] nir/spirv: cast shift operand to u32

2018-11-13 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Cc: mesa-sta...@lists.freedesktop.org On Tue, Nov 13, 2018 at 9:48 AM Karol Herbst wrote: > v2: fix for specialization constants as well > > Signed-off-by: Karol Herbst > --- > src/compiler/spirv/spirv_to_nir.c | 20 > src/compiler/spirv/vtn_al

[Mesa-dev] [PATCH 05/22] nir/spirv: cast shift operand to u32

2018-11-13 Thread Karol Herbst
v2: fix for specialization constants as well Signed-off-by: Karol Herbst --- src/compiler/spirv/spirv_to_nir.c | 20 src/compiler/spirv/vtn_alu.c | 11 +++ 2 files changed, 31 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/sp