Re: [Mesa-dev] [PATCH 05/14] i965: Merge variable hashtables of fs and vec4 visitors

2014-05-28 Thread Pohjolainen, Topi
On Wed, May 28, 2014 at 10:46:42AM -0700, Matt Turner wrote: > On Wed, May 28, 2014 at 10:43 AM, Matt Turner wrote: > > Doesn't backend_visitor need to have a destructor that calls > > hash_table_dtor? > > Ah, next patch. Good catch, it is a rebase error of mine. It definitely belongs here. ___

Re: [Mesa-dev] [PATCH 05/14] i965: Merge variable hashtables of fs and vec4 visitors

2014-05-28 Thread Matt Turner
On Wed, May 28, 2014 at 10:43 AM, Matt Turner wrote: > Doesn't backend_visitor need to have a destructor that calls hash_table_dtor? Ah, next patch. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/m

Re: [Mesa-dev] [PATCH 05/14] i965: Merge variable hashtables of fs and vec4 visitors

2014-05-28 Thread Matt Turner
On Wed, May 28, 2014 at 5:36 AM, Topi Pohjolainen wrote: > Now empty destructors are dropped allowing compiler to generate the > defaults (calling base class). > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_fs.h | 2 -- > src/mesa/drivers/dri/i965/brw_fs_vi

[Mesa-dev] [PATCH 05/14] i965: Merge variable hashtables of fs and vec4 visitors

2014-05-28 Thread Topi Pohjolainen
Now empty destructors are dropped allowing compiler to generate the defaults (calling base class). Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_fs.h | 2 -- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 8 src/mesa/drivers/dri/i965/brw_shader.cpp