Re: [Mesa-dev] [PATCH 05/14] glsl: Add IR builder support for function calls.

2013-10-23 Thread Francisco Jerez
Ian Romanick writes: > On 10/01/2013 07:15 PM, Francisco Jerez wrote: >>[..] >> +ir_call * >> +call(ir_function *f, ir_variable *ret, int num_params, ...) > > varargs functions that take an explicit count are very susceptible to > copy-and-past bugs. If you copy-and-paste an invocation, add or r

Re: [Mesa-dev] [PATCH 05/14] glsl: Add IR builder support for function calls.

2013-10-22 Thread Ian Romanick
On 10/01/2013 07:15 PM, Francisco Jerez wrote: > --- > src/glsl/ir_builder.cpp | 25 + > src/glsl/ir_builder.h | 8 > 2 files changed, 33 insertions(+) > > diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp > index 98b4322..1913c72 100644 > --- a/sr

[Mesa-dev] [PATCH 05/14] glsl: Add IR builder support for function calls.

2013-10-01 Thread Francisco Jerez
--- src/glsl/ir_builder.cpp | 25 + src/glsl/ir_builder.h | 8 2 files changed, 33 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp index 98b4322..1913c72 100644 --- a/src/glsl/ir_builder.cpp +++ b/src/glsl/ir_builder.cpp @@ -21,6 +2