Re: [Mesa-dev] [PATCH 05/12] panfrost: Determine framebuffer format bits late

2019-03-11 Thread Alyssa Rosenzweig
> Can we use a constant instead? The right solution is to actually RE the format bits for SFBD (which will be necessary if we're serious about supporting https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 05/12] panfrost: Determine framebuffer format bits late

2019-03-11 Thread Tomeu Vizoso
On Sun, 10 Mar 2019 at 07:50, Alyssa Rosenzweig wrote: > > Again, these formats are only properly known at the time of fragment job > emit. Rather than hardcoding the format, at least for MFBD we begin to > construct the format bits on-demand. This cleans up the code, > futureproofs for ES3 frameb

[Mesa-dev] [PATCH 05/12] panfrost: Determine framebuffer format bits late

2019-03-09 Thread Alyssa Rosenzweig
Again, these formats are only properly known at the time of fragment job emit. Rather than hardcoding the format, at least for MFBD we begin to construct the format bits on-demand. This cleans up the code, futureproofs for ES3 framebuffer formats, and should fix bugs regarding FBO colour swizzles.