Re: [Mesa-dev] [PATCH 05/11] compiler/blob: Add a concept of a fixed-allocation blob

2017-10-12 Thread Jordan Justen
I think the commit message should include something like: With a fixed allocation blob, the data buffer is managed by the caller, and can't be grown by blob writes. I also think it'd be better to add the NULL fixed allocation blob support in a separate patch. (It looks like the real motivation is

Re: [Mesa-dev] [PATCH 05/11] compiler/blob: Add a concept of a fixed-allocation blob

2017-10-11 Thread Nicolai Hähnle
On 11.10.2017 22:38, Jason Ekstrand wrote: --- src/compiler/blob.c | 24 +--- src/compiler/blob.h | 23 ++- 2 files changed, 43 insertions(+), 4 deletions(-) diff --git a/src/compiler/blob.c b/src/compiler/blob.c index 0b42871..59ad8a3 100644 --- a/src

[Mesa-dev] [PATCH 05/11] compiler/blob: Add a concept of a fixed-allocation blob

2017-10-11 Thread Jason Ekstrand
--- src/compiler/blob.c | 24 +--- src/compiler/blob.h | 23 ++- 2 files changed, 43 insertions(+), 4 deletions(-) diff --git a/src/compiler/blob.c b/src/compiler/blob.c index 0b42871..59ad8a3 100644 --- a/src/compiler/blob.c +++ b/src/compiler/blob.c @@ -5