Re: [Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-17 Thread Connor Abbott
On Wed, Dec 17, 2014 at 5:59 PM, Jason Ekstrand wrote: > > > On Wed, Dec 17, 2014 at 11:51 AM, Connor Abbott wrote: >> >> One thing I'm a little worried about is that passes might forget to >> require the right metadata, and they'll just happen to work since the >> pass before also requires the s

Re: [Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-17 Thread Matt Turner
On Wed, Dec 17, 2014 at 11:51 AM, Connor Abbott wrote: > One thing I'm a little worried about is that passes might forget to > require the right metadata, and they'll just happen to work since the > pass before also requires the same metadata and preserves it. I think > a good thing to do to comba

Re: [Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-17 Thread Jason Ekstrand
On Wed, Dec 17, 2014 at 11:51 AM, Connor Abbott wrote: > > One thing I'm a little worried about is that passes might forget to > require the right metadata, and they'll just happen to work since the > pass before also requires the same metadata and preserves it. I think > a good thing to do to com

Re: [Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-17 Thread Connor Abbott
One thing I'm a little worried about is that passes might forget to require the right metadata, and they'll just happen to work since the pass before also requires the same metadata and preserves it. I think a good thing to do to combat this is to have a debug mode that dirties *all* the metadata i

Re: [Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-17 Thread Connor Abbott
On Wed, Dec 17, 2014 at 7:04 AM, Jason Ekstrand wrote: > > > On Tue, Dec 16, 2014 at 10:58 PM, Connor Abbott wrote: >> >> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand >> wrote: >> > --- >> > src/glsl/Makefile.sources| 1 + >> > src/glsl/nir/nir.c | 19 +++- >> > sr

Re: [Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-17 Thread Matt Turner
On Wed, Dec 17, 2014 at 4:04 AM, Jason Ekstrand wrote: > On Tue, Dec 16, 2014 at 10:58 PM, Connor Abbott wrote: >> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand >> wrote: >> > +/** >> > + * Various bits of metadata that can may be created or required by >> > + * optimization and analysis passe

Re: [Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-17 Thread Jason Ekstrand
On Tue, Dec 16, 2014 at 10:58 PM, Connor Abbott wrote: > > On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand > wrote: > > --- > > src/glsl/Makefile.sources| 1 + > > src/glsl/nir/nir.c | 19 +++- > > src/glsl/nir/nir.h | 21 -- > > src/glsl/nir/

Re: [Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > --- > src/glsl/Makefile.sources| 1 + > src/glsl/nir/nir.c | 19 +++- > src/glsl/nir/nir.h | 21 -- > src/glsl/nir/nir_dominance.c | 6 ++--- > src/glsl/nir/nir_metadata.c | 52 > +

[Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-15 Thread Jason Ekstrand
--- src/glsl/Makefile.sources| 1 + src/glsl/nir/nir.c | 19 +++- src/glsl/nir/nir.h | 21 -- src/glsl/nir/nir_dominance.c | 6 ++--- src/glsl/nir/nir_metadata.c | 52 5 files changed, 82 insertions