Re: [Mesa-dev] [PATCH 04/13] nir: Collapse more repeated bcsels on the same argument

2018-08-03 Thread Ian Romanick
On 08/02/2018 05:52 PM, Timothy Arceri wrote: > I thought you were trying to move these type of opts to your new pass? > > Or should I be splitting out and resending some of the bcsel opts in my > dirt showdown patch [1]? And trying again to get the other patches from > the series reviewed. The n

Re: [Mesa-dev] [PATCH 04/13] nir: Collapse more repeated bcsels on the same argument

2018-08-02 Thread Timothy Arceri
I thought you were trying to move these type of opts to your new pass? Or should I be splitting out and resending some of the bcsel opts in my dirt showdown patch [1]? And trying again to get the other patches from the series reviewed. [1] https://lists.freedesktop.org/archives/mesa-dev/2018-

Re: [Mesa-dev] [PATCH 04/13] nir: Collapse more repeated bcsels on the same argument

2018-08-02 Thread Jason Ekstrand
Crazy... R-b On August 2, 2018 11:19:44 "Ian Romanick" wrote: From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277230 -> 14277220 (<.01%) instructions in affected programs: 751 -> 741 (-1.33%) helped: 4 HURT: 0 helped s

[Mesa-dev] [PATCH 04/13] nir: Collapse more repeated bcsels on the same argument

2018-08-02 Thread Ian Romanick
From: Ian Romanick All Gen platforms had pretty similar results. (Skylake shown) total instructions in shared programs: 14277230 -> 14277220 (<.01%) instructions in affected programs: 751 -> 741 (-1.33%) helped: 4 HURT: 0 helped stats (abs) min: 2 max: 3 x̄: 2.50 x̃: 2 helped stats (rel) min: 1.2