Re: [Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

2015-05-05 Thread Kenneth Graunke
On Tuesday, May 05, 2015 02:31:39 PM Jason Ekstrand wrote: > On Tue, May 5, 2015 at 1:34 PM, Matt Turner wrote: > > On Tue, May 5, 2015 at 1:13 PM, Jason Ekstrand wrote: > >> On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke > >> wrote: > >>> 2. CSE didn't use equals(), so it allowed things like

Re: [Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

2015-05-05 Thread Jason Ekstrand
On Tue, May 5, 2015 at 1:34 PM, Matt Turner wrote: > On Tue, May 5, 2015 at 1:13 PM, Jason Ekstrand wrote: >> On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke >> wrote: >>> 2. CSE didn't use equals(), so it allowed things like types to differ, >>>or source modifiers...(which are probably bo

Re: [Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

2015-05-05 Thread Matt Turner
On Tue, May 5, 2015 at 1:13 PM, Jason Ekstrand wrote: > On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke > wrote: >> 2. CSE didn't use equals(), so it allowed things like types to differ, >>or source modifiers...(which are probably bogus on LOAD_PAYLOADs >>anyway, so it may be moot...) >

Re: [Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

2015-05-05 Thread Jason Ekstrand
On Tue, Apr 14, 2015 at 1:28 AM, Kenneth Graunke wrote: > On Wednesday, April 01, 2015 06:19:15 PM Jason Ekstrand wrote: >> This allows us to combine code in CSE and register coalesce >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 14 ++ >> src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

2015-04-14 Thread Kenneth Graunke
On Wednesday, April 01, 2015 06:19:15 PM Jason Ekstrand wrote: > This allows us to combine code in CSE and register coalesce > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 14 ++ > src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 18 > +- > sr

[Mesa-dev] [PATCH 04/13] i965/fs_inst: Add an is_copy_payload helper

2015-04-01 Thread Jason Ekstrand
This allows us to combine code in CSE and register coalesce --- src/mesa/drivers/dri/i965/brw_fs.cpp | 14 ++ src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 18 +- src/mesa/drivers/dri/i965/brw_fs_register_coalesce.cpp | 14 +- sr