Re: [Mesa-dev] [PATCH 04/12] nir: Add a LCSAA-pass

2016-12-21 Thread Jason Ekstrand
On Tue, Dec 20, 2016 at 8:03 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Tue, 2016-12-20 at 15:14 -0800, Jason Ekstrand wrote: > > I did have a couple of "real" comments on this one that I'd like to > > at least see a reply to. Does look pretty good though. > > > > On Sun, Dec

Re: [Mesa-dev] [PATCH 04/12] nir: Add a LCSAA-pass

2016-12-20 Thread Timothy Arceri
On Tue, 2016-12-20 at 15:14 -0800, Jason Ekstrand wrote: > I did have a couple of "real" comments on this one that I'd like to > at least see a reply to.  Does look pretty good though. > > On Sun, Dec 18, 2016 at 9:47 PM, Timothy Arceri bora.com> wrote: > > From: Thomas Helland > > > > V2: Do a

Re: [Mesa-dev] [PATCH 04/12] nir: Add a LCSAA-pass

2016-12-20 Thread Timothy Arceri
On Tue, 2016-12-20 at 16:34 -0800, Jason Ekstrand wrote: > On Tue, Dec 20, 2016 at 3:36 PM, Timothy Arceri bora.com> wrote: > > On Tue, 2016-12-20 at 15:14 -0800, Jason Ekstrand wrote: > > > I did have a couple of "real" comments on this one that I'd like > > to > > > at least see a reply to.  Doe

Re: [Mesa-dev] [PATCH 04/12] nir: Add a LCSAA-pass

2016-12-20 Thread Jason Ekstrand
On Tue, Dec 20, 2016 at 3:36 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Tue, 2016-12-20 at 15:14 -0800, Jason Ekstrand wrote: > > I did have a couple of "real" comments on this one that I'd like to > > at least see a reply to. Does look pretty good though. > > > > On Sun, Dec

Re: [Mesa-dev] [PATCH 04/12] nir: Add a LCSAA-pass

2016-12-20 Thread Timothy Arceri
On Tue, 2016-12-20 at 15:14 -0800, Jason Ekstrand wrote: > I did have a couple of "real" comments on this one that I'd like to > at least see a reply to.  Does look pretty good though. > > On Sun, Dec 18, 2016 at 9:47 PM, Timothy Arceri bora.com> wrote: > > From: Thomas Helland > > > > V2: Do a

Re: [Mesa-dev] [PATCH 04/12] nir: Add a LCSAA-pass

2016-12-20 Thread Jason Ekstrand
I did have a couple of "real" comments on this one that I'd like to at least see a reply to. Does look pretty good though. On Sun, Dec 18, 2016 at 9:47 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > From: Thomas Helland > > V2: Do a "depth first search" to convert to LCSSA > > V3:

[Mesa-dev] [PATCH 04/12] nir: Add a LCSAA-pass

2016-12-18 Thread Timothy Arceri
From: Thomas Helland V2: Do a "depth first search" to convert to LCSSA V3: Small comment fixup V4: Rebase, adapt to removal of function overloads V5: Rebase, adapt to relocation of nir to compiler/nir Still need to adapt to potential if-uses Work around nir_validate issue V6 (Timothy)