Re: [Mesa-dev] [PATCH 04/10] mesa: Check isES before calling validate_io

2016-05-24 Thread Ian Romanick
On 05/20/2016 05:46 PM, Timothy Arceri wrote: > On Fri, 2016-05-20 at 00:25 -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> There's going to be a second validate_io function, and checking the >> same >> thing twice is silly. > > I think we should just do this check > in _mesa_validate_prog

Re: [Mesa-dev] [PATCH 04/10] mesa: Check isES before calling validate_io

2016-05-20 Thread Timothy Arceri
On Fri, 2016-05-20 at 00:25 -0700, Ian Romanick wrote: > From: Ian Romanick > > There's going to be a second validate_io function, and checking the > same > thing twice is silly. I think we should just do this check inĀ _mesa_validate_program_pipeline() before we callĀ _mesa_validate_pipeline_io()

[Mesa-dev] [PATCH 04/10] mesa: Check isES before calling validate_io

2016-05-20 Thread Ian Romanick
From: Ian Romanick There's going to be a second validate_io function, and checking the same thing twice is silly. Signed-off-by: Ian Romanick --- src/mesa/main/shader_query.cpp | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/shader_query.cpp b