Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2017-01-12 Thread Daniel Stone
Hi, On 10 January 2017 at 10:46, Daniel Stone wrote: > On 10 January 2017 at 05:49, Ben Widawsky wrote: >>> I ask because I genuinely don't know how this stuff is supposed to work. >>> Returning a default of 1 seems reasonable. >> >> I'm not entirely sure about a reasonable default, 1 seemed rig

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2017-01-11 Thread Jason Ekstrand
On Tue, Jan 10, 2017 at 2:46 AM, Daniel Stone wrote: > Hi, > > On 10 January 2017 at 05:49, Ben Widawsky > wrote: > > On 17-01-09 11:56:04, Jason Ekstrand wrote: > >> Do we need to do any error checking here? Do we need to check for the > >> right dri image extension version? Do we need to che

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2017-01-10 Thread Daniel Stone
Hi, On 10 January 2017 at 05:49, Ben Widawsky wrote: > On 17-01-09 11:56:04, Jason Ekstrand wrote: >> Do we need to do any error checking here? Do we need to check for the >> right dri image extension version? Do we need to check queryImage != >> NULL? Do we need to check a return value? >> >>

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2017-01-09 Thread Ben Widawsky
On 17-01-09 11:56:04, Jason Ekstrand wrote: On Thu, Dec 1, 2016 at 2:09 PM, Ben Widawsky wrote: From: Ben Widawsky This will be used by clients that need to know the number of planes allocated for them on behalf of the GL or other API. The best current example of this is when an extra "plane

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2017-01-09 Thread Jason Ekstrand
On Thu, Dec 1, 2016 at 2:09 PM, Ben Widawsky wrote: > From: Ben Widawsky > > This will be used by clients that need to know the number of planes > allocated for them on behalf of the GL or other API. The best current > example of this is when an extra "plane" is allocated to store > compression

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2017-01-02 Thread Ben Widawsky
On 16-12-02 17:57:40, Eric Engestrom wrote: On Thursday, 2016-12-01 14:09:44 -0800, Ben Widawsky wrote: From: Ben Widawsky This will be used by clients that need to know the number of planes allocated for them on behalf of the GL or other API. The best current example of this is when an extra

Re: [Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2016-12-02 Thread Eric Engestrom
On Thursday, 2016-12-01 14:09:44 -0800, Ben Widawsky wrote: > From: Ben Widawsky > > This will be used by clients that need to know the number of planes > allocated for them on behalf of the GL or other API. The best current > example of this is when an extra "plane" is allocated to store > compr

[Mesa-dev] [PATCH 03/27] gbm: Export a plane getter function

2016-12-01 Thread Ben Widawsky
From: Ben Widawsky This will be used by clients that need to know the number of planes allocated for them on behalf of the GL or other API. The best current example of this is when an extra "plane" is allocated to store compression data for the primary plane. Cc: Daniel Stone Signed-off-by: Ben