Re: [Mesa-dev] [PATCH 03/10] nir: allow more nested loops to be unrolled

2018-07-22 Thread Timothy Arceri
On 22/07/18 19:32, Jason Ekstrand wrote: On Tue, Jul 10, 2018 at 11:49 PM Timothy Arceri > wrote: The innermost check was added to stop us from unrolling multiple loops in a single pass, and to stop outer loops from unrolling. Do you mean "multiple nested

Re: [Mesa-dev] [PATCH 03/10] nir: allow more nested loops to be unrolled

2018-07-22 Thread Jason Ekstrand
On Tue, Jul 10, 2018 at 11:49 PM Timothy Arceri wrote: > The innermost check was added to stop us from unrolling multiple > loops in a single pass, and to stop outer loops from unrolling. > Do you mean "multiple nested loops in a single pass..."? > When we successfully unroll a loop we need to

[Mesa-dev] [PATCH 03/10] nir: allow more nested loops to be unrolled

2018-07-10 Thread Timothy Arceri
The innermost check was added to stop us from unrolling multiple loops in a single pass, and to stop outer loops from unrolling. When we successfully unroll a loop we need to run the analysis pass again before deciding if we want to go ahead an unroll a second loop. However the logic was flawed b