Re: [Mesa-dev] [PATCH 02/44] nir: Get rid of the variable on vote intrinsics

2017-10-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 05/09/17 16:12, Jason Ekstrand wrote: This looks like a copy+paste error. They don't actually write into that variable as would be implied by putting the return there. --- src/compiler/glsl/glsl_to_nir.cpp | 2 -- src/compiler/nir/nir_intrinsics.h | 6 +++--

[Mesa-dev] [PATCH 02/44] nir: Get rid of the variable on vote intrinsics

2017-09-05 Thread Jason Ekstrand
This looks like a copy+paste error. They don't actually write into that variable as would be implied by putting the return there. --- src/compiler/glsl/glsl_to_nir.cpp | 2 -- src/compiler/nir/nir_intrinsics.h | 6 +++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler